Conversation
github-actions
bot
added
go
RiSKeD
reviewed
Jan 23, 2026
pkg/framework/framework.go
Outdated
Comment on lines
+52
to
+63
| if internalError != nil && testError == nil { | ||
| t.Result = ResultInternalFailure | ||
| t.ErrorText = internalError.Error() | ||
| } else if testError != nil && internalError == nil { | ||
| t.ErrorText = testError.Error() | ||
| t.Result = ResultFail | ||
| } else if rc { | ||
| t.Result = ResultSuccess | ||
| } else { | ||
| t.Result = ResultFail | ||
| } | ||
| return t.Result == ResultSuccess |
There was a problem hiding this comment.
shouldn't internal error always "overrule" a test error? With this behavior internal errors are only propagated if the test error is nil. Also i personally prefer a switch-case over if-clause chaining.
pkg/tests/ipmi_sensor.go
Outdated
| return false, nil, err | ||
| } | ||
|
|
||
| pattern := `POH Counter :\s+\d+\s*days,\s+\d+\s*hours` |
There was a problem hiding this comment.
this regex could be precompiled instead
ChriMarMe
force-pushed
the
dev
branch
3 times, most recently
from
a1d80ed to
f6fb63f
Compare
Collaborator
|
Out of curiosity, should this close #12 ? |
ChriMarMe
force-pushed
the
dev
branch
10 times, most recently
from
6e7be0a to
42fd423
Compare
ChriMarMe
force-pushed
the
dev
branch
5 times, most recently
from
9656f15 to
7a8fe80
Compare
By adding this capability it will be possible to supply device specific expected information by a config file. Signed-off-by: Christopher Meis <christopher.meis@9elements.com>
ChriMarMe
force-pushed
the
dev
branch
7 times, most recently
from
3c07a32 to
c22486f
Compare
ChriMarMe
force-pushed
the
dev
branch
4 times, most recently
from
63f22f1 to
9480f28
Compare
ChriMarMe
force-pushed
the
dev
branch
6 times, most recently
from
8591490 to
7f2c155
Compare
This commit provides the basic framework, interfaces and some tests as example for futher extention. Signed-off-by: Christopher Meis <christopher.meis@9elements.com>
Previously, newHost dialed SSH immediately at device initialization, causing failures when the host OS hadn't finished booting yet or when running BMC-only suites that don't need host access. Now the SSH connection is established on first use via ExecuteCommandLine. Signed-off-by: llogen <christoph.lange@blindspot.software>
Show both expected and actual GUID in the error message to make mismatches immediately obvious. Signed-off-by: llogen <christoph.lange@blindspot.software>
Signed-off-by: Christopher Meis <christopher.meis@9elements.com>
Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 6 to 7. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](goreleaser/goreleaser-action@v6...v7) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Christopher Meis <christopher.meis@9elements.com>
This test allows to test bmc firmware downgrade and upgrade via redfish. Signed-off-by: Christopher Meis <christopher.meis@9elements.com>
github-actions
bot
added
the
documentation
Signed-off-by: Christopher Meis <christopher.meis@9elements.com>
Replace os.ExpandEnv with a helper that also resolves a leading ~/ to the user's home directory, fixing "no such file or directory" errors when paths like ~/Downloads/image.mtd are passed via env vars. Signed-off-by: llogen <christoph.lange@blindspot.software>
The existing test had multiple issues: ~ not expanded in image paths, no waiting for BMC to go down before declaring it up, no task polling before triggering Manager.Reset, stale Redfish session after reboot, and immediate exit on downgrade failure leaving the BMC on old firmware. Replace the naive fire-and-forget logic with flashAndWait, which handles both auto-reboot (static.mtd.tar) and manual-reset (.static.mtd) image formats, reconnects the Redfish client after each reboot, and always restores the CI image regardless of test outcome. Signed-off-by: llogen <christoph.lange@blindspot.software>
The flag was redundant since ssh_key in the host config already provides the key path after env expansion at load time. Signed-off-by: llogen <christoph.lange@blindspot.software>
Signed-off-by: Christopher Meis <christopher.meis@9elements.com>
Signed-off-by: Christopher Meis <christopher.meis@9elements.com>
Signed-off-by: llogen <christoph.lange@blindspot.software>
Signed-off-by: Christopher Meis <christopher.meis@9elements.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR shall provide the initial new structures and flows.